Add a TypeSystemSwiftTypeRef::GetTupleElementName() method. #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
approved these changes
Oct 27, 2020
| return name->getText().str(); | ||
| } | ||
| std::string name; | ||
| llvm::raw_string_ostream(name) << idx; |
There was a problem hiding this comment.
What's the use case for returning the index if it has no name?
There was a problem hiding this comment.
This function is needed by TypeSystemSwiftTypeRef::GetChildCompilerTypeAtIndex().
The implicit name of an unnamed tuple element is 0:, 1:, ... . See https://github.com/apple/llvm-project/blob/46170cc2f5a9af3db7652ef119ecee0dbc78392d/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp#L7018
| @@ -258,6 +258,10 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift { | |||
| bool print_help_if_available, bool print_extensions_if_available, | |||
| lldb::DescriptionLevel level = lldb::eDescriptionLevelFull) override; | |||
|
|
|||
| /// Return the nth tuple element's name, if it has one. | |||
There was a problem hiding this comment.
Suggested change
| /// Return the nth tuple element's name, if it has one. | |
| /// Return the nth tuple element's name, or its index as a string if it has no name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.