Cherry-pick FindTypes API modernization #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I think this should go to apple/stable/... |
|
You're right, it's not like these cherry-picks actually contain the merge conflict resolutions. |
I noticed that SymbolFileDWARFDebugMap::FindTypes was implementing it incorrectly (passing append=false in a for-loop to recursive calls to FindTypes would yield only the very last set of results), but instead of fixing it, removing it seemed like an even better option. rdar://problem/54412692 Differential Revision: https://reviews.llvm.org/D68171 llvm-svn: 373224 (cherry picked from commit d4d428e)
llvm-svn: 373250 (cherry picked from commit b0ccef1)
This is untested, I don't have access to a Windows machine. llvm-svn: 373342 (cherry picked from commit 796cd31)
In r368345 I accidentally introduced a regression that would over-report the number of matches found by FindTypes if the DeclContext Filter was hit. This patch simply removes the size_t return parameter altogether — it's not that useful. rdar://problem/55500457 Differential Revision: https://reviews.llvm.org/D68169 llvm-svn: 373344 (cherry picked from commit bf9d84c)
llvm-svn: 373352 (cherry picked from commit 771d464)
llvm-svn: 373353 (cherry picked from commit c7f19ca)
llvm-svn: 373354 (cherry picked from commit ad08a5f)
llvm-svn: 373355 (cherry picked from commit dffe5df)
llvm-svn: 373373 (cherry picked from commit f3d2158)
The original test was passing false to the append argument of FindTypes (the only use of this feature!). This patch now replicates that by passing a fresh TypeMap into the function where applicable. llvm-svn: 373409 (cherry picked from commit e2385e0)
llvm-svn: 373968 (cherry picked from commit 69a3b21)
Differential Revision: https://reviews.llvm.org/D68595 llvm-svn: 374080 (cherry picked from commit bde5a6a)
adrian-prantl
force-pushed
the
55500457
branch
from
e2149e6 to
09ba1c9
Compare
adrian-prantl
changed the base branch from
swift/master
to
apple/stable/20190619
|
@swift-ci test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.