[lldb] Use reflection to get the dynamic type of a class #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (objc_runtime->GetDynamicTypeAndAddress( | ||
| in_value, use_dynamic, class_type_or_name, address, value_type)) { | ||
| bool found = false; | ||
| ForEachSuperClassType(in_value, [&](SuperClassType sc) -> bool { |
There was a problem hiding this comment.
Can you add a comment here explaining why we are filtering out private Foundation types?
| @@ -4,7 +4,7 @@ | |||
| // REQUIRES: system-darwin | |||
| // REQUIRES: swift | |||
|
|
|||
| // RUN: %lldb --repl < %s 2>&1 | FileCheck %s | |||
| // RUN: %lldb --repl < %s | FileCheck %s | |||
There was a problem hiding this comment.
why do we need to filter out stderr output?
There was a problem hiding this comment.
Some unrelated warnings were making this test fail, so I thought I'd remove stderr since that's not what the test is checking for.
There was a problem hiding this comment.
Hmm, yeah. It doesn't seem to be necessary given the CHECK lines.
augusto2112
force-pushed
the
remove-remoteast-from-GetDynamicTypeAndAddress_Class
branch
from
375a0fa to
824e91c
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Aug 31, 2021
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Ran tests locally and don't see any failures caused by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.