Skip to content

[lldb][testsuite] Refactor use of check_expression #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chelcassanova
Copy link

Several API tests were defining their own versions of check_expression that performed the same task. lldbutil has its own check_expression function and this commit replaces the self-defined check_expression with the lldbutil version.

Referred to in: rdar://32228544

Several API tests were defining their own versions of `check_expression`
that performed the same task. lldbutil has its own `check_expression` function
and this commit replaces the self-defined `check_expression` with the
lldbutil version.

Referred to in: rdar://32228544
Copy link

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelcassanova chelcassanova merged commit 570c7a4 into swiftlang:stable/20230725 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants