Skip to content

Guard tests with REQUIRES:aarch64-registered-target #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rastogishubham
Copy link

@rastogishubham rastogishubham commented Sep 26, 2023

(cherry picked from commit 579ccc3)

@rastogishubham
Copy link
Author

@swift-ci please test llvm

Copy link

@dsandersllvm dsandersllvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. LGTM without the change that moved Red outside the enum. I also had a couple notes

@cachemeifyoucan
Copy link

cachemeifyoucan commented Sep 26, 2023

The correct spelling for the requirement is REQUIRES: aarch64-registered-target, not arm64.

Just like @dsandersllvm says, if the test is put in a sub directory that has the name of the target, usually you just put the requirement in the lit.local.cfg in that directory. You just need to follow the file example like: https://github.com/apple/llvm-project/blob/next/llvm/test/CodeGen/AArch64/lit.local.cfg so you don't need to repeat the require line in each test.

@rastogishubham
Copy link
Author

@swift-ci please test llvm

@rastogishubham
Copy link
Author

@swift-ci please test llvm

@rastogishubham rastogishubham changed the title Guard tests with REQUIRES:arm64 Guard tests with REQUIRES:aarch64-registered-target Sep 26, 2023
@rastogishubham rastogishubham merged commit d7d8d50 into swiftlang:stable/20230725 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants