Skip to content

[lldb] Re-enable TestSwiftTaskSwitch #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kastiglione
Copy link

No description provided.

@kastiglione
Copy link
Author

@swift-ci test

Copy link

@bulbazord bulbazord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@kastiglione kastiglione marked this pull request as draft September 26, 2023 20:59
@kastiglione
Copy link
Author

Letting it run tests on CI

@etcwilde
Copy link

Do we know why this test is passing now?

@kastiglione
Copy link
Author

@etcwilde Felipe (@felipepiovezan) suggested it was fixed by this #7489

@etcwilde
Copy link

Okay, cool. Thank you. Just wanted to check that there was an associated change and we weren't just pulling the xfail off because "it looks fine on the bots". That PR looks like it was merged reasonably within the timeframe that the test started UPASS'ing.

Copy link

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures on macOS look consistent with re-enabling this test.
These are current.

2 warning(s) in tests
********************
Failed Tests (3):
  lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py
  lldb-api :: lang/objc/real-definition/TestRealDefinition.py
  lldb-api :: lang/swift/async/stepping/step-in/TestSwiftStepInAsync.py

********************
Unexpectedly Passed Tests (2):
  lldb-api :: lang/swift/async/stepping/step-in/task-switch/TestSwiftTaskSwitch.py
  lldb-shell :: Register/x86-64-write.test

The test failures on the macOS bot for this PR are the same, but without the UPASS in TestSwiftTaskSwitch.py.

@etcwilde
Copy link

Windows Swift failures are known. We aren't yet to testing LLDB there, so this should be fine in that regard.

Failed Tests (6):
  Swift(windows-x86_64) :: DebugInfo/implicitreturn.swift
  Swift(windows-x86_64) :: Driver/Dependencies/only-skip-once.swift
  Swift(windows-x86_64) :: IRGen/c_globals.swift
  Swift(windows-x86_64) :: IRGen/framepointer.sil
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-inline-irgen.swift
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-out-of-line-irgen.swift

@adrian-prantl adrian-prantl marked this pull request as ready for review September 28, 2023 19:17
@adrian-prantl adrian-prantl merged commit d3d9ccb into stable/20230725 Sep 28, 2023
@kastiglione kastiglione deleted the dl/lldb-Re-enable-TestSwiftTaskSwitch branch October 3, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants