-
Notifications
You must be signed in to change notification settings - Fork 340
[lldb] Re-enable TestSwiftTaskSwitch #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lldb] Re-enable TestSwiftTaskSwitch #7523
Conversation
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
Letting it run tests on CI |
Do we know why this test is passing now? |
@etcwilde Felipe (@felipepiovezan) suggested it was fixed by this #7489 |
Okay, cool. Thank you. Just wanted to check that there was an associated change and we weren't just pulling the xfail off because "it looks fine on the bots". That PR looks like it was merged reasonably within the timeframe that the test started UPASS'ing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures on macOS look consistent with re-enabling this test.
These are current.
2 warning(s) in tests
********************
Failed Tests (3):
lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py
lldb-api :: lang/objc/real-definition/TestRealDefinition.py
lldb-api :: lang/swift/async/stepping/step-in/TestSwiftStepInAsync.py
********************
Unexpectedly Passed Tests (2):
lldb-api :: lang/swift/async/stepping/step-in/task-switch/TestSwiftTaskSwitch.py
lldb-shell :: Register/x86-64-write.test
The test failures on the macOS bot for this PR are the same, but without the UPASS in TestSwiftTaskSwitch.py
.
Windows Swift failures are known. We aren't yet to testing LLDB there, so this should be fine in that regard.
|
No description provided.