[LiveDebugValues] Remove swift customizations introducing entry values #7716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new approach to entry values, codegen no longer needs to get involved, so these LDV customizations are no longer needed. These were particularly problematic as they were re-introducing entry values in the "entry funclet" of certain swift async functions. (cherry picked from commit 56252e3)
|
@swift-ci please test |
adrian-prantl
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new approach to entry values, codegen no longer needs to get involved, so these LDV customizations are no longer needed.
These were particularly problematic as they were re-introducing entry values in the "entry funclet" of certain swift async functions.
(cherry picked from commit 56252e3)
The stable branch version of #7715