Skip to content

[lldb][NFCI] Remove ObjectFile::GetReflectionSectionIdentifier #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bulbazord
Copy link

ObjectFile doesn't need to know what swift is. The only place this method got used was in SwiftLanguageRuntime, which already has functionality to replace this entirely (which I just moved up).

ObjectFile doesn't need to know what swift is. The only place this
method got used was in SwiftLanguageRuntime, which already has
functionality to replace this entirely (which I just moved up).
Copy link

@augusto2112 augusto2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bulbazord
Copy link
Author

@swift-ci please test

@bulbazord bulbazord merged commit 6c6872b into swiftlang:stable/20230725 Jan 25, 2024
@bulbazord bulbazord deleted the 20230725-reflection-is-no-object branch January 25, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants