Skip to content

Revert "Reland [clang] Canonicalize system headers in dependency file… #7773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benlangmuir
Copy link

… when -canonical-prefixes" (llvm#71697)

This reverts commit 578a471.

This causes multiple issues. Compile time slowdown due to more path canonicalization, and weird behavior on Windows.

Will reland under a separate flag -f[no-]canonical-system-headers to match gcc in the future and further limit when it's passed by default.

Fixes llvm#70011.

(cherry picked from commit 955dd88)

rdar://118178759

… when -canonical-prefixes" (llvm#71697)

This reverts commit 578a471.

This causes multiple issues. Compile time slowdown due to more path
canonicalization, and weird behavior on Windows.

Will reland under a separate flag `-f[no-]canonical-system-headers` to
match gcc in the future and further limit when it's passed by default.

Fixes llvm#70011.

(cherry picked from commit 955dd88)

rdar://118178759
@benlangmuir
Copy link
Author

@swift-ci please test

@benlangmuir
Copy link
Author

swiftlang/swift#69749
@swift-ci please test

@benlangmuir benlangmuir merged commit 7acad9a into swiftlang:stable/20230725 Nov 9, 2023
@benlangmuir benlangmuir deleted the revert-canonical-path-regression branch November 9, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants