[lldb] Implement check for potential Swift interop types in DWARF #8009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cheaper pre-check for Swift/C++ interop types when parsing the type in DWARF.
|
@swift-ci test |
|
@adrian-prantl this is a potential solution to avoid completing the types when checking if they're Swift interop types. It does require iterating over the type's first level children when first parsing the type (before completing it). |
adrian-prantl
approved these changes
Jan 23, 2024
| bool DWARFASTParserClang::IsSwiftInteropType(const DWARFDIE &die) { | ||
| for (DWARFDIE die : die.children()) | ||
| if (die.Tag() == llvm::dwarf::DW_TAG_member && | ||
| llvm::StringRef(die.GetName()) == "__swift_mangled_name") |
There was a problem hiding this comment.
Regarding a conversation @felipepiovezan and I had offline about query APIs: I'm curious if this if (die.GetName() == string) also happens often enough to warrant a faster die.IsName(string) API.
There was a problem hiding this comment.
Probably worth having a die.CompareName(other) method too, as it is always faster to compare it that way in the negative case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cheaper pre-check for Swift/C++ interop types when parsing the type in DWARF.