Skip to content

[lldb] Fix use-after-free of StringRefs in GetNominal #8026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[lldb] Fix use-after-free of StringRefs in GetNominal #8026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,7 @@ GetNominal(swift::Demangle::Demangler &dem, swift::Demangle::NodePointer node) {

/// Return a pair of module name and type name, given a mangled name.
static llvm::Optional<std::pair<StringRef, StringRef>>
GetNominal(llvm::StringRef mangled_name) {
swift::Demangle::Demangler dem;
GetNominal(llvm::StringRef mangled_name, swift::Demangle::Demangler &dem) {
auto *node = GetDemangledType(dem, mangled_name);
/// Builtin names belong to the builtin module, and are stored only with their
/// mangled name.
Expand Down Expand Up @@ -1826,7 +1825,9 @@ TypeSystemSwiftTypeRef::FindTypeInModule(opaque_compiler_type_t opaque_type) {
auto *M = GetModule();
if (!M)
return {};
auto module_type = GetNominal(AsMangledName(opaque_type));

swift::Demangle::Demangler dem;
auto module_type = GetNominal(AsMangledName(opaque_type), dem);
if (!module_type)
return {};
// DW_AT_linkage_name is not part of the accelerator table, so
Expand Down