Skip to content

[lldb] Change swift-allow-explicit-modules setting default to true #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

No description provided.

@kastiglione kastiglione marked this pull request as draft February 29, 2024 22:34
@kastiglione
Copy link
Author

Depends on swiftlang/swift#71987

@kastiglione kastiglione changed the title [lldb] Enable explicit modules in lldb when testing explicit module builds [lldb] Change swift-allow-explicit-modules setting default to true Feb 29, 2024
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test windows

@kastiglione
Copy link
Author

I'll hold off on merging until swiftlang/swift#71987 has had time to propagate.

@kastiglione
Copy link
Author

kastiglione commented Mar 5, 2024

With the changes made in #8335, this can be merged without a wait period. It no longer depends only on swiftlang/swift#71987.

@kastiglione kastiglione marked this pull request as ready for review March 5, 2024 14:54
@kastiglione kastiglione merged commit 7fe0912 into stable/20230725 Mar 5, 2024
@kastiglione kastiglione deleted the dl/lldb-Enable-explicit-modules-in-lldb-when-testing-explicit-module-builds branch March 5, 2024 14:57
kastiglione added a commit that referenced this pull request Mar 7, 2024
kastiglione added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant