Thread llvm::Expected through SwiftASTContext::Reconstruct type #8503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all the way to the expression evaluator. Without this change a user would see a misleading error: <EXPR>:8:1: cannot find 'variable' in scope instead of pointing at the missing debug info for variable's type. rdar://125613361
|
@augusto2112 @kastiglione I had to redo this to store all errors in the list of variables instead of returning expected from ASTManipulator, because we expect in some testcases to have an expression succeed despite some variables (that aren't referenced in the expression) failing to lookup. The new patch touches more code, but it's all still very mechanical. |
|
@swift-ci test |
|
@augusto2112 @kastiglione I'm going to merge this now, but I would still appreciate some post-commit feedback if you can take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Thread llvm::Expected through SwiftASTContext::Reconstruct type all the way to the expression evaluator. Without this change a user would see a misleading
instead of pointing at the missing debug info for variable's type.
rdar://125613361