Add a new SBExpressionOptions::SetLanguage() API #8657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test windows |
that separates out language and version. To avoid reinventing the wheel and introducing subtle incompatibilities, this API uses the table of languages and versiond defined by the upcoming DWARF 6 standard (https://dwarfstd.org/languages-v6.html). While the DWARF 6 spec is not finialized, the list of languages is broadly considered stable. The primary motivation for this is to allow the Swift language plugin to switch between language dialects between, e.g., Swift 5.9 and 6.0 with out introducing a ton of new language codes. On the main branch this change is considered NFC. Depends on llvm#89980 (cherry picked from commit 975eca0) Conflicts: lldb/packages/Python/lldbsuite/test/dotest_args.py lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/source/Expression/UserExpression.cpp
This patch adds DWARF constants for DW_AT_language_name and DW_AT_language_version to Dwarf.def and Dwarf.h. While the DWARF 6 spec is not finalized, the constants are published on the DWARF website and considered stable, with idea being that the list published on dwarfstd.org is the authoritative source that is being continuously updated between DWARF revisions, as new languages are being developed. https://dwarfstd.org/languages-v6.html My main motivation for adding this is to use in llvm#89981 (cherry picked from commit 300340f)
… type. rdar://126783312
(cherry picked from commit 4cd11c9)
adrian-prantl
force-pushed
the
126783312-6.0
branch
from
c2c2f23 to
6b475c6
Compare
(cherry picked from commit b88d211) Conflicts: lldb/packages/Python/lldbsuite/test/builders/builder.py
adrian-prantl
force-pushed
the
126783312-6.0
branch
from
6b475c6 to
2c21b76
Compare
Use a Python script to generate SBLanguages.h instead of piggybacking on LLDB TableGen. This addresses Nico Weber's post-commit feedback. (cherry picked from commit dcbf0fc)
|
@swift-ci test |
JDevlieghere
approved these changes
May 1, 2024
(cherry picked from commit b8c301f)
|
@swift-ci test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://126783312