[lldb] Add setting to override ClangImporter driver options #8682
Conversation
|
@swift-ci test |
| // the first argument. | ||
| raw_args.push_back("clang"); | ||
| for (const std::string &arg : args) | ||
| raw_args.push_back(arg.data()); |
There was a problem hiding this comment.
I find this very scary because we don't know if args contents is nullterminated and it's easy to break this contract in the future.
Could we just make this a std::vector<std::string>?
There was a problem hiding this comment.
the type of args is std::vector<std::string>.
If you are referring to raw_args and its type llvm::SmallVector<const char *, 64>, note that it's used because that's the signature of clang::driver::applyOverrideOptions.
There was a problem hiding this comment.
Oh, I see!
Is the null-terminator guaranteed, or should this be arg.c_str()?
There was a problem hiding this comment.
it's guaranteed to be null terminated:
The returned array is null-terminated, that is,
data()andc_str()perform the same function. (since C++11)
|
@swift-ci test |
|
@swift-ci test |
kastiglione
deleted the
dl/lldb-Add-setting-to-override-ClangImporter-driver-options
branch
Introduce the
target.swift-clang-override-optionssetting, which provides the debugger the same functionality asCCC_OVERRIDE_OPTIONS. This is useful as an additional means to workaround issues that can arise with ClangImporter options. This is more powerful than the existingtarget.swift-extra-clang-flagssetting, which only allows flags to be added, not deleted or rewritten.Depends on llvm#85425