Skip to content

[lldb] Add non-Apple implementation of GetSDKPathFromDebugInfo #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

bnbarham
Copy link

PlatformDarwin::GetSDKPathFromDebugInfo is only available on Apple platforms, add an empty implementation of GetSDKPathFromDebugInfo to prevent linkage errors.

@bnbarham bnbarham requested a review from Michael137 July 12, 2024 19:21
@bnbarham bnbarham requested a review from JDevlieghere as a code owner July 12, 2024 19:21
Copy link

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move the ifdef into GetSDKPathFromDebugInfo?

@bnbarham
Copy link
Author

bnbarham commented Jul 12, 2024

Why not move the ifdef into GetSDKPathFromDebugInfo?

I can do that if you prefer, it'd just ifdef out the entire body still.

EDIT: Updated, assuming you wouldn't ask the question if it wasn't what you wanted :)

`PlatformDarwin::GetSDKPathFromDebugInfo` is only available on Apple
platforms, add an empty implementation of `GetSDKPathFromDebugInfo` to
prevent linkage errors.
@bnbarham bnbarham merged commit 900b6fc into swiftlang:stable/20240625 Jul 12, 2024
@bnbarham bnbarham deleted the fix-linux-build branch July 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants