Skip to content

[asan][windows] Make tests more flexable (#85274) (Cherrypick) #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

usama54321
Copy link

Contains test changes from
llvm#81677 that are simple test changes. For the most part just makes the tests allow more flexibility in the callstacks produced by asan.

Note: this PR has the exact changes from
llvm#81677 in addition to a revert commit to remove the ones that require other things from that PR. This will be squashed, ofc. I just left things unsquashed for reviewing pleasure :).

This is a non-functional-change

Contains test changes from
llvm#81677 that are simple test
changes. For the most part just makes the tests allow more flexibility
in the callstacks produced by asan.

Note: this PR has the exact changes from
llvm#81677 in addition to a revert
commit to remove the ones that require other things from that PR. This
will be squashed, ofc. I just left things unsquashed for reviewing
pleasure :).

This is a non-functional-change
@usama54321
Copy link
Author

@swift-ci test

@usama54321
Copy link
Author

@swift-ci test platform windows

@usama54321
Copy link
Author

@swift-ci Please test Windows platform

@devincoughlin devincoughlin self-requested a review July 29, 2024 18:15
Copy link

@devincoughlin devincoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test-only change.

@devincoughlin devincoughlin merged commit 37a037b into swiftlang:swift/release/6.0 Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants