[Test] Fix Profile-arm64.ContinuousSyncMode.darwin-proof-of-concept.c #9702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm#100469) …greater than the maximum for a segment This test was failing with: ``` -- Exit Code: 1 Command Output (stderr): -- ld: warning: reducing alignment of section __DATA,__pcnts from 0x4000 to 0x1000 because it exceeds segment maximum alignment ld: warning: reducing alignment of section __DATA,__pdata from 0x4000 to 0x1000 because it exceeds segment maximum alignment __pdata not ordered after __pcnts. -- ``` (cherry picked from commit 99bb9a7)
Fix profile/darwin-proof-of-concept.c on AppleSilicon Mac where there is a different page alignment. The previous fix to drop alignment is actually breaking the tests on Apple Silicon Mac. Revert to the original section alignment and requires an ARM64 target for this test to run. (cherry picked from commit d2a8351)
|
@swift-ci please test |
nkcsgexi
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://138555312