Skip to content

Don’t return edits from ExecuteCommandRequest #1498

Closed
@ahoppen

Description

@ahoppen

Currently, the ExecuteCommandRequest is returning the edits it wants to perform to the source file as the LSPAny response. Clients shouldn’t know how to interpret that LSPAny and the edits are actually applied by sending a ApplyEditRequest to the client.

Only tests are currently relying on the response of the ExecuteCommandRequest. We should change those tests to test the actual ApplyEditRequest sent to the client and make ExecuteCommandRequest return an empty response.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions