Skip to content

LanguageServerProtocol: handle new files with CMake #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Dec 7, 2022

New files not available to CMake cause build failures on Windows.

New files not available to CMake causes build failures on Windows.
@MaxDesiatov MaxDesiatov added bug Something isn't working Windows Windows platform support labels Dec 7, 2022
@MaxDesiatov MaxDesiatov requested a review from compnerd December 7, 2022 16:01
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@compnerd
Copy link
Member

compnerd commented Dec 7, 2022

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Dec 7, 2022

@shahmishal could we get CI setup to get triggered for Windows here as well?

@MaxDesiatov MaxDesiatov merged commit 5b16c3e into main Dec 7, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/fix-missing-cmake-files branch December 7, 2022 17:22
@ahoppen
Copy link
Member

ahoppen commented Dec 7, 2022

Sorry, I forgot to add them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows Windows platform support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants