Inclusive language: rename master object file to prelinked object file #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames occurrences of "master" in relation to this feature to "prelink" or "prelinked". There are 3 remaining exceptions, which is to default the GENERATE_PRELINK_OBJECT_FILE build setting to GENERATE_MASTER_OBJECT_FILE for backwards compatibility.
jakepetroules
requested review from
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
jakepetroules
commented
Apr 28, 2025
| "[GENERATE_MASTER_OBJECT_FILE]-name" = "Perform Single-Object Prelink"; | ||
| "[GENERATE_MASTER_OBJECT_FILE]-description" = "Activating this setting will cause the object files built by a target to be prelinked using `ld -r` into a single object file, and that object file will then be linked into the final product. This is useful to force the linker to resolve symbols and link the object files into a single module before building a static library. Also, a separate set of link flags can be applied to the prelink allowing additional control over, for instance, exported symbols."; | ||
| "[GENERATE_PRELINK_OBJECT_FILE]-name" = "Perform Single-Object Prelink"; | ||
| "[GENERATE_PRELINK_OBJECT_FILE]-description" = "Activating this setting will cause the object files built by a target to be prelinked using `ld -r` into a single object file, and that object file will then be linked into the final product. This is useful to force the linker to resolve symbols and link the object files into a single module before building a static library. Also, a separate set of link flags can be applied to the prelink allowing additional control over, for instance, exported symbols."; |
There was a problem hiding this comment.
"PRELINK" here rather than "PRELINKED" since there are two other build settings used for this spec which are already called "PRELINK" (see below)
owenv
approved these changes
Apr 28, 2025
This was referenced Apr 29, 2025
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 29, 2025
Fixing build failure in https://ci.swift.org/job/oss-swift-pr-test-macoss/4978/console introduced by swiftlang/swift-build#452.
jakepetroules
added a commit
that referenced
this pull request
Apr 30, 2025
Missed this in #452, just going it add it for now while we're merging branches around to reduce the chance of things going wrong.
jakepetroules
added a commit
that referenced
this pull request
Apr 30, 2025
Missed this in #452, just going it add it for now while we're merging branches around to reduce the chance of things going wrong.
jakepetroules
added a commit
that referenced
this pull request
Apr 30, 2025
Missed this in #452, just going it add it for now while we're merging branches around to reduce the chance of things going wrong.
jakepetroules
added a commit
that referenced
this pull request
Apr 30, 2025
Missed this in #452, just going it add it for now while we're merging branches around to reduce the chance of things going wrong.
ldaley
pushed a commit
to ldaley/swift-build
that referenced
this pull request
May 13, 2025
Missed this in swiftlang#452, just going it add it for now while we're merging branches around to reduce the chance of things going wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames occurrences of "master" in relation to this feature to "prelink" or "prelinked". There are 3 remaining exceptions, which is to default the GENERATE_PRELINK_OBJECT_FILE build setting to GENERATE_MASTER_OBJECT_FILE for backwards compatibility.