Skip to content

build: link against shared BlocksRuntime #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

compnerd
Copy link
Member

This allows libdispatch to build BlocksRuntime shared.

This allows libdispatch to build BlocksRuntime shared.
@parkera
Copy link
Contributor

parkera commented Jun 28, 2018

Are we going to ditch the implementation in Foundation then?

@alblue
Copy link
Contributor

alblue commented Jun 29, 2018

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2018

@parkera - that would totally be an option - we could end up with a single implementation, which would be an improvement.

@parkera
Copy link
Contributor

parkera commented Jul 3, 2018

I always thought that the Swift runtime should include the C blocks library on Linux.

@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2018

@parkera - yeah, that makes sense to me, especially since blocks are woven into the language itself. Unfortunately, I don't know how to best accomplish that move. I think that once we can have a shared BlocksRuntime, it should be possible to actually move the source into the swift repository and have it be provided by the swift runtime.

@parkera
Copy link
Contributor

parkera commented Jul 5, 2018

Ok

@compnerd
Copy link
Member Author

Lets get this bit merged. Since it doesn't break the build even without the library being converted, it reduces the number of outstanding changes and simplifies the effort to switch to it.

@compnerd compnerd merged commit b2b14cc into swiftlang:master Jul 18, 2018
@compnerd compnerd deleted the shared-blocks branch July 18, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants