Various Cookie fixes

[maksimorlovich]

• Add support for additional Set-Cookie formats that web servers can return
• Properly handle HTTP header parsing to extract values since values can contain colons
• Make sure to set cookies on redirect requests
• Use setValue instead of addValue when applying cookies to requests otherwise,
  Cookie header might contain: cookie1=value1,cookie1=value1; cookie2=value2
• New unit tests for cookie formats and redirect with Set-Cookie

[maksimorlovich]

@mamabusi, @ianpartridge, @spevans, please kindly review this change. Thank you! :)

[spevans]

@swift-ci test

[maksimorlovich]

@swift-ci, could this please be retested? Looks like the build failed in files not touched by my commit... Thanks!

[spevans]

@swift-ci test

[maksimorlovich]

@spevans, looks like this is not a new failure, older PR #1697, and newer PR #1701 fail the same way on macOS.

[parkera]

Glad to see we're actually testing on macOS now. We can merge this if others approve and address those separately.

[maksimorlovich]

@mamabusi, @ianpartridge, could I please get a review? Thanks!

[ianpartridge]

This all looks sensible to me, but I can't comment on compatibility with Darwin. Does Foundation on Darwin support the extra Set-Cookie formats, for example?

[maksimorlovich]

@ianpartridge, yes, I checked against swift 4.2 release on Darwin and indeed it does support these four cookie formats. Thanks!

[mamabusi]

LGTM.
Thanks @maksimorlovich

[ianpartridge]

@swift-ci please test and merge

[maksimorlovich]

Thanks @mamabusi and @ianpartridge!

@ianpartridge, I would like to get this into the next 4.2.x release. Is swift-4.2-branch the correct one for the 4.2.x release? Thanks!

[ianpartridge]

Yes I think so - @parkera can confirm that that branch is still accepting fixes.

[jrose-apple]

It looks like this broke Ubuntu 14.04; please fix that first! https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/5915/

[maksimorlovich]

@jrose-apple, the compiler error appears to be unrelated to my changes:
clang: error: no such file or directory: 'tools/SourceKit/tools/sourcekitd/bin/InProc/CMakeFiles/sourcekitdInProc.dir/sourcekitdInProc.cpp.o'

Looks like a setup issue? I'm surprised Ubuntu 16.04 builds just fine.

[jrose-apple]

No, that's an unrelated error we haven't tracked down, but not a fatal one. Here's the actual error:

04:09:27 Test Case 'TestHTTPCookie.test_cookieExpiresDateFormats' started at 2018-09-25 09:09:20.681
04:09:27 TestFoundation/TestHTTPCookie.swift:190: error: TestHTTPCookie.test_cookieExpiresDateFormats : XCTAssertEqual failed: ("Optional(0020-01-01 12:30:00 +0000)") is not equal to ("Optional(2020-01-01 12:30:00 +0000)") - 
04:09:27 Test Case 'TestHTTPCookie.test_cookieExpiresDateFormats' failed (0.006 seconds)
04:09:27 Test Suite 'TestHTTPCookie' failed at 2018-09-25 09:09:20.687
04:09:27 	 Executed 8 tests, with 1 failure (0 unexpected) in 0.02 (0.02) seconds

[ianpartridge]

@jrose-apple do we need to revert this PR while we figure out the 14.04 test failure?

[spevans]

Given the use of dates in the tests, it could be ICU on 14.04 causing problems. The usual fix is to disable the tests

[maksimorlovich]

@jrose-apple, sorry I didn't catch this error. I will have a fix shortly. Thanks for your help in identifying the failure!

[maksimorlovich]

@jrose-apple, here's the fix for Ubuntu 14.04: #1707 Thanks! Can swift-ci test on Ubuntu 14.04 please?