FileManager: correct API misuse on Windows #3049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetVolumeInformationW` is documented as taking the root directory of the volume to describe as `lpRootPathName`. We attempt to compute the location by determining the volume mount point where the specified path is mounted. However, `GetVolumePathNameW` does always return the path to the volume mount point, which is the root of the volume where the specified path. With a path substitution that is not rooted at a volume root, the volume root with a relative path. As we need to get to the root, force the stripping to the root via `PathCchStripToRoot`. This should repair the TestFoundation.TestFileManager/test_filesystemAttributes on Windows.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetVolumeInformationWis documented as taking the root directory ofthe volume to describe as
lpRootPathName. We attempt to compute thelocation by determining the volume mount point where the specified
path is mounted. However,
GetVolumePathNameWdoes always return thepath to the volume mount point, which is the root of the volume where
the specified path. With a path substitution that is not rooted at a
volume root, the volume root with a relative path. As we need to get
to the root, force the stripping to the root via
PathCchStripToRoot.This should repair the
TestFoundation.TestFileManager/test_filesystemAttributes on Windows.