Base.subproject: correct home directory handling on Windows #4692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
lorentey
approved these changes
Jan 20, 2023
Prefer to use `NetUserGetInfo` over enumerating all users as that is unnecessary. Correct the string handling where we used `CFStringCreateWithBytesNoCopy` which expects the input to be in an 8-bit encoding which we do not use (nor does Windows support for the SAM access). This corrects the string manipulation which improves the test suite pass rate though some errors still remain.
compnerd
force-pushed
the
home-sweet-home
branch
from
47d3bab to
4964737
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we can enumerate the users using
NetUserEnum, that does not guarantee that we get the full user information. Perform an explicitNetUserGetInfoto query the user information to get the home directory.Additionally, correct the
CFStringhandling within the function where we were improperly usingCFStringCreateWithBytesNoCopywhich requires that the string is 8-bit encoded. We now useCFStringCreateWithCharacters[NoCopy]to properly create theCFStringwith unicode characters.