[SR-7039] can't use -static-stdlib (or -static-executable) with any Dispatch using app

[weissi]

Previous ID	SR-7039
Radar	rdar://problem/38913393
Original Reporter	@weissi
Type	Bug
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	6
Component/s	libdispatch
Labels	Bug
Assignee	@spevans
Priority	Medium

md5: b75d9276b711df9f7b981f99923ed483

is duplicated by:

• SR-7085 Link error related to libdispatch when using -static-stdlib on Linux

relates to:

• SR-9368 libdispatch_static unit tests are disabled
• SR-10625 tests for -static-*

Issue Description:

repro

mkdir /tmp/test && cd /tmp/test && swift package init --type=executable
cat > Sources/test/main.swift <<EOF
import Dispatch
let q = DispatchQueue(label: "q")
q.sync { print("hello") }
EOF
swift build -Xswiftc -static-stdlib

expected

works, just like without the -static-stdlib

actual

$ rm -rf .build && /usr/local/swift/swift-4.0.2-RELEASE-ubuntu16.04/usr/bin/swift build -Xswiftc -static-stdlib
Compile Swift Module 'test' (1 sources)
Linking ./.build/x86_64-unknown-linux/debug/test
/usr/bin/ld.gold: error: cannot find -ldispatch
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCMa'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA0_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA1_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA2_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA3_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfC'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
error: terminated(1): /usr/local/swift/swift-4.0.2-RELEASE-ubuntu16.04/usr/bin/swift-build-tool -f /tmp/test/.build/debug.yaml main

cause

libdispatch.a isn't shipped even though it could be. Since this patch libdispatch.a should work but it needs to be compiled with

./configure --enable static=yes

[belkadan]

I was pretty sure we fixed this in 4.1. Can you check there?

[belkadan]

dgrove-oss (JIRA User), any insights?

[swift-ci]

Comment by David Grove (JIRA)

At least in the snapshot build I just grabbed, there was a libdisaptch.so, but not a libdispatch.a. I'd speculate there's still a missing bit of CMake configuration that is causing libdispatch.a to either not be built or to not be installed.

@compnerd any thoughts?

dgrove$ find . -name "dispatch"
./swift-DEVELOPMENT-SNAPSHOT-2018-02-26-a-ubuntu16.04/usr/lib/swift/dispatch
./swift-DEVELOPMENT-SNAPSHOT-2018-02-26-a-ubuntu16.04/usr/lib/swift/dispatch/dispatch.h
./swift-DEVELOPMENT-SNAPSHOT-2018-02-26-a-ubuntu16.04/usr/lib/swift/linux/libdispatch.so

[compnerd]

shared builds are the default, and I wouldn't be surprised if we weren't enabling static builds. Passing -DBUILD_SHARED_LIBS=NO to the cmake invocation should help.

[weissi]

@swift-ci create

[weissi]

this is still an issue. For example, compiling NIO (https://github.com/apple/swift-nio) fails with

 undefined reference to '_Block_copy'
 undefined reference to '_NSConcreteStackBlock'
 undefined reference to '_T08Dispatch0A13WorkItemFlagsVACSu8rawValue_tcfC'
 undefined reference to '_T08Dispatch0A3QoSV11unspecifiedACvau'
 undefined reference to '_T08Dispatch0A4TimeV17uptimeNanosecondss6UInt64Vvg'
 undefined reference to '_T08Dispatch0A4TimeV1loiSbAC_ACtFZ'
 undefined reference to '_T08Dispatch0A4TimeV3nowACyFZ'
 undefined reference to '_T08Dispatch0A4TimeVACs6UInt64V17uptimeNanoseconds_tcfC'
 undefined reference to '_T08Dispatch0A5GroupC4waityyF'
 undefined reference to '_T08Dispatch0A5GroupC5enteryyF'
 undefined reference to '_T08Dispatch0A5GroupC5leaveyyF'
 undefined reference to '_T08Dispatch0A5GroupC6notifyyAA0A3QoSV3qos_AA0A13WorkItemFlagsV5flagsAA0A5QueueC5queueyyXB7executetF'
 undefined reference to '_T08Dispatch0A5GroupCACycfc'
 undefined reference to '_T08Dispatch0A5GroupCMa'
 undefined reference to '_T08Dispatch0A5GroupCN'
 undefined reference to '_T08Dispatch0A5QueueC10AttributesVAEs6UInt64V8rawValue_tcfC'
 undefined reference to '_T08Dispatch0A5QueueC4syncyyyc7execute_tF'
 undefined reference to '_T08Dispatch0A5QueueC5asyncyAA0A5GroupCSg5group_AA0A3QoSV3qosAA0A13WorkItemFlagsV5flagsyyXB7executetF'
 undefined reference to '_T08Dispatch0A5QueueC6globalAcA0A3QoSV0D6SClassO3qos_tFZ'
 undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfC'
 undefined reference to '_T08Dispatch0A5QueueCMa'
 undefined reference to '_T08Dispatch0A5QueueCN'
 undefined reference to '_T08Dispatch0A8WorkItemC4waityyF'
 undefined reference to '_T08Dispatch0A8WorkItemC7performyyF'
 undefined reference to '_T08Dispatch0A8WorkItemCAcA0A3QoSV3qos_AA0abC5FlagsV5flagsyyXB5blocktcfc'
 undefined reference to '_T08Dispatch0A8WorkItemCMa'
 undefined reference to '_T08Dispatch0A8WorkItemCN'
 undefined reference to '_T08Dispatch0A9SemaphoreC4waityyF'
 undefined reference to '_T08Dispatch0A9SemaphoreC6signalSiyF'
 undefined reference to '_T08Dispatch0A9SemaphoreCACSi5value_tcfc'
 undefined reference to '_T08Dispatch0A9SemaphoreCMa'

[compnerd]

Just a note, setting {{BUILD_SHARED_LIBS}} to {{NO}} does in fact build the static libdispatch.

[weissi]

@compnerd thanks but BUILD_SHARED_LIBS=NO implies that we then wouldn't build the shared libs. Is there a way to build both and can we enable that by default?

Still fails on 4.1 release

root@9c37f1ac9294:/tmp/test# swiftc -version
Swift version 4.1 (swift-4.1-RELEASE)
Target: x86_64-unknown-linux-gnu
root@9c37f1ac9294:/tmp/test# swift build -Xswiftc -static-stdlib
Linking ./.build/x86_64-unknown-linux/debug/test
/usr/bin/ld.gold: error: cannot find -ldispatch
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCMa'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA0_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA1_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA2_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfcfA3_'
/tmp/test/Sources/test/main.swift:2: error: undefined reference to '_T08Dispatch0A5QueueCACSS5label_AA0A3QoSV3qosAC10AttributesV10attributesAC20AutoreleaseFrequencyO011autoreleaseI0ACSg6targettcfC'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
error: terminated(1): /usr/bin/swift-build-tool -f /tmp/test/.build/debug.yaml main output:

[compnerd]

Unfortunately, there is no way to do that currently. CMake only builds a single type of library by default. I think that doing two CMake invocations is probably the best solution here as it avoids any custom machinery for building both types of libraries. I will note that it is possible to generate both libraries, but requires adding custom logic in the CMake build.

[weissi]

@compnerd the old build system supported that so this is a regression, should we just do two invocations for now to fix this?

[swift-ci]

Comment by Matt Wright (JIRA)

This seems like you wheelhouse?

[compnerd]

@weissi - yeah, I think that we should do two invocations for now.

[weissi]

Ok, perfect, thank you!

[swift-ci]

Comment by Aleksei Cherepanov (JIRA)

@compnerd could you show how to build in this way?

[swift-ci]

Comment by Joel Saltzman (JIRA)

ftp27 (JIRA User) I think they mean append it to the build commands here:

cmake -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DBUILD_SHARED_LIBS=NO <path-to-source>

from here at the very bottom: https://github.com/apple/swift-corelibs-libdispatch/blob/master/INSTALL.md

Also, I'm not sure what to pass in addition to "swift build -Xswiftc -static-stdlib" to link to the lib