-
Notifications
You must be signed in to change notification settings - Fork 470
Remove version number used in 'available' attribute for non-specific platform '*'. #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we care about watchOS and tvOS too? tvOS version numbers match iOS's, but watchOS's don't. |
I agree with Jordan - the tvOS and watchOS deprecations should also be included. |
I don't think I or Ding knows for sure what those should be! It's also a little funny that these are just in corelibs-dispatch, which is never used on iOS/tvOS/watchOS. Or did we miss some in the overlays too? |
Thank you for the feedbacks, Jordan and Kim! Can we just remove those lines of |
I suspect that SCD is trying to match the contents of the Darwin overlay exactly for most of these files, and that they should therefore be kept in sync. |
Alright, let's keep it in sync. This is a conservative solution anyway. |
@swift-ci Please test Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me as it is. I think we need to review whether any of these @available lines are required as a separate exercise.
Remove version number used in 'available' attribute for non-specific platform '*'. Signed-off-by: Kim Topley <[email protected]>
This patch aims to make swift-corelibs-libdispatch adapted to this PR, which warns for version number in 'available' attribute for non-specific platform '*'.