Skip to content

build: remove unnecessary flag to control the linker #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

compnerd
Copy link
Member

The SWIFT_LINKER_FLAGS allows the user to specify the linker that they
want for Swift and C/C++ have their own flags which let you control
flags which should permit control of the C/C+ linker. This removes the
unnecessary logic for controlling the linker. This simplification
always paves the way for migrating further to CMake 3.15+.

@compnerd
Copy link
Member Author

@swift-ci please test

@ktopley-apple
Copy link
Contributor

@compnerd looks like you forgot to remove the dispatch_set_linker(dispatch) call in src/CMakeLists.txt.

The `SWIFT_LINKER_FLAGS` allows the user to specify the linker that they
want for Swift and C/C++ have their own flags which let you control
flags which should permit control of the C/C+ linker.  This removes the
unnecessary logic for controlling the linker.  This simplification
always paves the way for migrating further to CMake 3.15+.
@ktopley-apple
Copy link
Contributor

@swift-ci please test

@ktopley-apple ktopley-apple merged commit 90a45ce into swiftlang:master Aug 26, 2019
@compnerd compnerd deleted the linker-be-gone branch August 26, 2019 21:24
rokhinip pushed a commit that referenced this pull request Nov 5, 2021
build: remove unnecessary flag to control the linker
Signed-off-by: Rokhini Prabhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants