build: make some linkage flags public #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the compiler and linker flags need to be used by dependent libraries which requires making the flags public so that users of the libraries and the export targets are setup properly.
|
@swift-ci please test |
|
@ktopley-apple - okay to merge? |
ktopley-apple
approved these changes
Oct 1, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: make some linkage flags public Signed-off-by: Rokhini Prabhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the compiler and linker flags need to be used by dependent libraries
which requires making the flags public so that users of the libraries and the
export targets are setup properly.