SwiftDriver: add support for resolving the registrar via SDKROOT #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a TODO to resolve the swift registrar via evaluation of `SDKROT` environment variable. The path is computed through an order preference of: 1. `-resource-dir` 2. `-sdk` 3. `SDKROOT` 4. toolchain relative resource directory This should enable the use of the swift driver to compile Swift code without needing to explicitly pass the `-sdk` parameter on Windows.
|
@swift-ci please test |
cltnschlosser
approved these changes
Mar 5, 2022
artemcm
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a TODO to resolve the swift registrar via evaluation of
SDKROTenvironment variable. The path is computed through an orderpreference of:
-resource-dir-sdkSDKROOTThis should enable the use of the swift driver to compile Swift code
without needing to explicitly pass the
-sdkparameter on Windows.