Skip to content

Revert "Update Generic Unix linker selection" #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented May 6, 2024

Reverts #1545

We're hitting issues where the driver is picking up BFD instead of Gold and mislinking:

error: link command failed with exit code 1 (use -v to see invocation)
/usr/bin/ld: /home/build-user/build/buildbot_linux/libdispatch-linux-x86_64/src/swift/CMakeFiles/swiftDispatch.dir/Block.swift.o: relocation R_X86_64_PC32 against protected symbol `$s8Dispatch0A13WorkItemFlagsVSYAAMc' can not be used when making a shared object
/usr/bin/ld: final link failed: bad value

Telling the built clang to use gold did not work so I'll need to figure out which clang the driver is trying to use here: swiftlang/swift#73463

@etcwilde etcwilde requested a review from drexin May 6, 2024 22:28
@etcwilde
Copy link
Contributor Author

etcwilde commented May 6, 2024

@swift-ci please test

@etcwilde etcwilde merged commit 59a7770 into main May 6, 2024
2 of 3 checks passed
@etcwilde etcwilde deleted the revert-1545-ewilde/linker-selection branch May 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants