Skip to content

[SwiftScanCAS] Make sure that CAS size limitation can take effect #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Apr 8, 2025

Previously the last CAS instance that was closing the database was not the one that was getting the CAS size limitation setting, resulting in the limit not being in effect.

rdar://148836977

Previously the last CAS instance that was closing the database was not the one
that was getting the CAS size limitation setting, resulting in the limit not being in effect.

rdar://148836977
@akyrtzi akyrtzi requested a review from cachemeifyoucan April 8, 2025 17:19
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Apr 8, 2025

@swift-ci Please test

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary workaround.

@akyrtzi akyrtzi merged commit b0027b6 into swiftlang:main Apr 9, 2025
3 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/fix-cas-size-limit branch April 9, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants