Skip to content

[Caching] Fix a fallout from block list remap #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Apr 10, 2025

Don't remap block list path from dependency scanning invocation.

This is a regression from #1858

rdar://149015672

@cachemeifyoucan cachemeifyoucan requested a review from artemcm April 10, 2025 19:03
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test linux platform

Don't remap block list path from dependency scanning invocation.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-block-list-remap-fallout branch from 57571cc to 2ce26d9 Compare April 10, 2025 19:41
@cachemeifyoucan
Copy link
Contributor Author

Test failure is because the compiler will crash if block list is empty. Workaround the issue by adding a key value pair inside while I add the fix to compiler.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan cachemeifyoucan merged commit 4fc019b into swiftlang:main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants