[Jobs] Switch EmitSupportedFeaturesJob to use `-emit-supported-argu…
#1875
Conversation
|
swiftlang/swift#80833 |
| @@ -31,7 +30,7 @@ extension Toolchain { | |||
| var commandLine: [Job.ArgTemplate] = swiftCompilerPrefixArgs.map { Job.ArgTemplate.flag($0) } | |||
| var inputs: [TypedVirtualPath] = [] | |||
| commandLine.append(contentsOf: [.flag("-frontend"), | |||
| .flag("-emit-supported-features")]) | |||
| .flag("-emit-supported-arguments")]) | |||
There was a problem hiding this comment.
We are in a place where, unfortunately, this code needs to be compatible with compilers that do not yet have swiftlang/swift#80833, so we must maintain compatibility with both. So we need something like:
if isFrontendArgSupported(.emitSupportedArguments) {
commandLine.append(.flag("-emit-supported-arguments"))
} else {
commandLine.append(.flag("-emit-supported-features"))
}
There was a problem hiding this comment.
Should I leave it as -features for now then?
There was a problem hiding this comment.
Btw, I don't think that we can actually do that since this call is the source of "supported arguments" :)
There is no cross-repository testing in this direction, so in order to test this in CI, swiftlang/swift#80833 needs to get merged and then make it into a nightly snapshot (which is what swift-driver CI uses). |
`-emit-supported-features` didn't actually support "features". The compiler now has an alias to `emit-supported-arguments` to make sure that this is not confused with `-print-supported-features` in the future.
xedin
force-pushed
the
emit-supported-arguments
branch
from
53070c0 to
87aec6a
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Closing this for now since we need maintain backward compatibility. |
…ments` option
This is a driver side change for swiftlang/swift#80833