Reduce buildBlock overloads with pairwise buildBlock(combining:into:)
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
pairwise-buildblock
branch
4 times, most recently
from
17f3055 to
2c66ee6
Compare
rxwei
changed the title
buildBlockbuildBlock overloads with pairwise buildBlock(combining:into:)
rxwei
force-pushed
the
pairwise-buildblock
branch
from
2c66ee6 to
ec66d20
Compare
rxwei
force-pushed
the
pairwise-buildblock
branch
from
ec66d20 to
97f4edc
Compare
This was referenced Jan 25, 2022
rxwei
force-pushed
the
pairwise-buildblock
branch
2 times, most recently
from
eede636 to
c9c9028
Compare
|
@swift-ci please test linux |
rxwei
force-pushed
the
pairwise-buildblock
branch
from
c9c9028 to
d853aae
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please clean test linux |
/build/branch-main/swift-experimental-string-processing/Sources/PatternConverter/PatternConverter.swift:69:18: error: ambiguous use of 'renderAsPattern(maxTopDownLevels:minBottomUpLevels:)'
00:23:28 let render = ast.renderAsPattern(
00:23:28 ^
00:23:28 /build/branch-main/swift-experimental-string-processing/Sources/_MatchingEngine/Regex/Printing/PrintAsPattern.swift:20:15: note: found this candidate
00:23:28 public func renderAsPattern(
00:23:28 ^
00:23:28 /build/branch-main/swift-experimental-string-processing/Sources/_StringProcessing/PrintAsPattern.swift:22:15: note: found this candidate
00:23:28 public func renderAsPattern(
00:23:28 ^Such a strange error. There's only one |
|
@swift-ci please clean test Linux |
rxwei
force-pushed
the
pairwise-buildblock
branch
from
d853aae to
e4529bc
Compare
|
@swift-ci please test Linux |
rxwei
force-pushed
the
pairwise-buildblock
branch
from
e4529bc to
5fe6e17
Compare
|
@swift-ci please clean test linux |
|
I suspect it's a stale file on the CI machine, and a clean test didn't fix it. I'll rename |
rxwei
force-pushed
the
pairwise-buildblock
branch
from
5fe6e17 to
bfe6ba7
Compare
…o:)`. This patch replaces `O(2^arity)` overloads of `buildBlock` with `O(arity^2)` overloads of `buildBlock(combining:into:)` with the language feature implemented in swiftlang/swift#40799. This improves library compilation time, and fixes an issue where nested captures did not have a flattened type. Before this patch, fixing this would need `O(arity!)` overloads. This also allows us to switch back to native tuples for `Match`. Also, rename `renderAsPattern` to `renderAsBuilderDSL` to work around a CI stale file issue.
rxwei
force-pushed
the
pairwise-buildblock
branch
from
bfe6ba7 to
8763e2d
Compare
|
@swift-ci please test Linux |
|
Merging to unblock things. Additional feedback welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces
O(2^arity)overloads ofbuildBlockwithO(arity^2)overloads ofbuildBlock(combining:into:)with the language feature implemented in swiftlang/swift#40799. This improves library compilation time, and fixes an issue where nested captures did not have a flattened type. Before this patch, fixing this would needO(arity!)overloads. This also allows us to switch back to native tuples forMatch.Also, rename
renderAsPatterntorenderAsBuilderDSLto work around a CI stale file issue.This depends on swift-DEVELOPMENT-SNAPSHOT-2022-02-03 or later.