Cleanups and refactorings #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rxwei I don't want to cause conflicts for your PRs, so this can wait until later to merge. |
|
@swift-ci please test linux platform |
rxwei
approved these changes
Feb 3, 2022
Comment on lines
250
to
255
| public protocol MatchProtocol { | ||
| associatedtype Capture | ||
| } | ||
| extension Substring: MatchProtocol { | ||
| public typealias Capture = EmptyCapture | ||
| } |
There was a problem hiding this comment.
FWIW, #127 removes MatchProtocol, so you can probably leave it here so that there's one fewer conflict.
|
@swift-ci please test linux platform |
|
Feel free to merge this as there's no ETA when a new toolchain will come out to unblock my PRs. |
milseman
force-pushed
the
code_grooming
branch
from
cb07403 to
aad7831
Compare
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSL/Core.swiftUtil/Errors.swiftfor ourUnsupportedandUnreachableerrors, and use them more broadlyDSLTree.swift