-
Notifications
You must be signed in to change notification settings - Fork 49
Rename RegexProtocol
to RegexComponent
and RegexBuilder
to RegexComponentBuilder
.
#200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One option is an ABI that takes |
Sure. My main concern was not about ABI, but whether it makes sense to have matching API on a |
@natecook1000 how are option scopes and global options coming along? That might help clarify the relationship between a |
@swift-ci please test |
…exComponentBuilder`. We've decided to use `RegexComponent` for the protocol, and use `RegexComponentBuilder` for the builder type since we want the user to import a module named `RegexBuilder` to get the DSL.
RegexBuilder
to RegexComponentBuilder
.
RegexBuilder
to RegexComponentBuilder
.RegexProtocol
to RegexComponent
and RegexBuilder
to RegexComponentBuilder
.
@swift-ci please test |
We converged on this solution in a meeting so I'll go ahead and merge. Any feedback is always welcome. |
…exComponentBuilder`. (swiftlang#200) We've decided to use `RegexComponent` for the protocol, and use `RegexComponentBuilder` for the builder type since we want the user to import a module named `RegexBuilder` to get the DSL.
…exComponentBuilder`. (swiftlang#200) We've decided to use `RegexComponent` for the protocol, and use `RegexComponentBuilder` for the builder type since we want the user to import a module named `RegexBuilder` to get the DSL.
…exComponentBuilder`. (swiftlang#200) We've decided to use `RegexComponent` for the protocol, and use `RegexComponentBuilder` for the builder type since we want the user to import a module named `RegexBuilder` to get the DSL.
We've decided to use
RegexComponent
for the protocol, and useRegexComponentBuilder
for the builder type since we want the user to import a module namedRegexBuilder
to get the DSL.