Skip to content

Add regex builder DSL pitch and update captures pitch #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2022
Merged

Add regex builder DSL pitch and update captures pitch #201

merged 4 commits into from
Mar 16, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 8, 2022 •
edited
Loading

  • Add a new pitch for the regex builder DSL.
  • Update the strongly typed regex captures pitch to the latest design.

@rxwei rxwei force-pushed the dsl-pitch branch 13 times, most recently from 8a9e44d to 74eddac Compare March 15, 2022 09:11
@rxwei rxwei changed the title Regex builder DSL pitch draft Add regex builder DSL pitch Mar 15, 2022
@rxwei rxwei marked this pull request as ready for review March 15, 2022 09:12
@rxwei rxwei force-pushed the dsl-pitch branch 3 times, most recently from a36e86d to 116ec95 Compare March 15, 2022 09:56
@rxwei rxwei changed the title Add regex builder DSL pitch Add regex builder DSL pitch and update captures pitch Mar 15, 2022
@rxwei rxwei force-pushed the dsl-pitch branch 6 times, most recently from e6e7971 to 8c94f7d Compare March 15, 2022 10:11
@rxwei
Add regex builder DSL pitch and update captures pitch.
4b80675 
- Add a new pitch for the regex builder DSL.
- Update the strongly typed regex captures pitch to the latest design.
rxwei added 3 commits March 15, 2022 14:57
@rxwei
Naming and typing changes related to Regex.
ce57780 
- `Regex<Output>` instead of `Regex<Match>`
- `Regex.init(_: String)` returns `Regex<AnyRegexOutput>` instead of `Regex<(Substring, DynamicCaptures)>`.
- `Regex<Output>.Match` instead of `MatchResult<Match>`. The new name corresponds better to the base name of `firstMatch(of:)`.
@rxwei
Fix AnyRegexOutput example.
414cdae
@rxwei
Fix typo Group -> Capture
d40fdda
@rxwei
Copy link
Contributor Author

rxwei commented Mar 16, 2022

@swift-ci please test

@rxwei rxwei merged commit 69d23a8 into swiftlang:main Mar 16, 2022
@rxwei rxwei deleted the dsl-pitch branch March 16, 2022 23:25
rxwei added a commit to rxwei/swift-experimental-string-processing that referenced this pull request Mar 18, 2022
@rxwei
Add regex builder DSL pitch and update captures pitch (swiftlang#201)
b65590f 
- Add a new pitch for the regex builder DSL.
- Update the strongly typed regex captures pitch to the latest design.
rxwei added a commit to rxwei/swift-experimental-string-processing that referenced this pull request Mar 21, 2022
@rxwei
Add regex builder DSL pitch and update captures pitch (swiftlang#201)
67e4fdd 
- Add a new pitch for the regex builder DSL.
- Update the strongly typed regex captures pitch to the latest design.
rxwei added a commit to rxwei/swift-experimental-string-processing that referenced this pull request Mar 21, 2022
@rxwei
Add regex builder DSL pitch and update captures pitch (swiftlang#201)
00a03cd 
- Add a new pitch for the regex builder DSL.
- Update the strongly typed regex captures pitch to the latest design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rxwei