Expanded options #246
Merged
Expanded options #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds methods to RegexComponent for the remainder of the regex options, and passes the current MatchingOptions further down into the consumers so that the correct behavior can be used.
The other changes here are to make the reluctant tests work as intended. Those tests require a full match, which was subverting the expected reluctance of `OneOrMore`.
natecook1000
commented
Apr 4, 2022
|
@swift-ci Please test |
|
@swift-ci Please test |
These are either unimplemented or don't really make sense as API.
|
@swift-ci Please test |
Azoy
pushed a commit
to Azoy/swift-experimental-string-processing
that referenced
this pull request
Apr 19, 2022
This adds methods to RegexComponent for the remainder of the regex options, and passes the current MatchingOptions further down into the consumers so that the correct behavior can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds methods to
RegexComponentfor the remainder of the regex options, and passes the currentMatchingOptionsfurther down into the consumers so that the correct behavior can be used.