Skip to content

Improve Unicode/UTS18 and semantic level support #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 5, 2022

Conversation

natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Apr 12, 2022

This adds test cases for the UTS18 level 1 and (part of the) level 2 recommendations: https://unicode.org/reports/tr18/

Still lots of tests to add, but this branch fixes several issues with handling Unicode property classes at different semantic levels.

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 marked this pull request as ready for review May 4, 2022 20:41
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 changed the title Add tests for UTS18 level support Improve Unicode/UTS18 and semantic level support May 5, 2022
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit 6d833aa into swiftlang:main May 5, 2022
@natecook1000 natecook1000 deleted the uts18_testcases branch May 5, 2022 21:16
hamishknight pushed a commit to hamishknight/swift-experimental-string-processing that referenced this pull request May 12, 2022
* Add tests for UTS18 level support (incomplete)
* Implement canonical equivalence tests
* Fix canonical equivalence at different levels
* Test named chars x semantic level
* Enable loose matching on \N{...} scalar names
* Make Unicode property classes work with semantics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants