Skip to content

Support obtaining captures by name on AnyRegexOutput #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Support obtaining captures by name on AnyRegexOutput #300

merged 1 commit into from
Apr 19, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Apr 19, 2022 •
edited
Loading 

extension Regex.Match where Output == AnyRegexOutput {
    public subscript(_ name: String) -> AnyRegexOutput.Element? { get }
}

extension AnyRegexOutput {
    public subscript(_ name: String) -> AnyRegexOutput.Element? { get }
}

Resolves #266.

@rxwei rxwei requested a review from milseman April 19, 2022 07:59
@rxwei
Copy link
Contributor Author

rxwei commented Apr 19, 2022

@swift-ci please test

milseman
milseman approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rxwei rxwei merged commit 9ccde19 into main Apr 19, 2022
@rxwei rxwei deleted the anyregexoutput-subscript-string branch April 19, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support obtaining captures by name on AnyRegexOutput
2 participants
@rxwei @milseman