Introduce new compiler interface #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the SPI interface `swiftCompilerLexRegexLiteral` and `swiftCompilerParseRegexLiteral` for the Swift compiler to call into. This allows us to avoid depending on other library API on the compiler side, while letting it keep the bridging gunk. While we're here, add an extra `String` return for the parsing function that could allow us to change the regex emission format in the future. This still needs to be plumbed through on the complier side though.
|
@swift-ci please test |
milseman
approved these changes
Apr 28, 2022
|
Yes, swiftlang/swift#58463 has the compiler side changes |
|
Ok, do we need to do something in lock-step, or can we do it over multiple PRs / commits? |
|
The compiler-side changes need to be applied with the next main -> swift/main merge. Unfortunately it seems a RegexBuilder change is currently blocking CI for that (https://ci.swift.org/job/swift-PR-Linux/1558). We could do possibly do a cherry-pick of this to swift/main in the mean time though, as I don't believe it should conflict with anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the SPI interface
swiftCompilerLexRegexLiteralandswiftCompilerParseRegexLiteralfor the Swift compiler to call into. This allows us to avoid depending on other library API on the compiler side, while letting it keep the bridging gunk.While we're here, add an extra
Stringreturn for the parsing function that could allow us to change the regex emission format in the future. This still needs to be plumbed through on the complier side though.