Skip to content

Add matching support for \p{Lc} and \p{L&} #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022

Conversation

hamishknight
Copy link
Contributor

This is defined in UAX#44 as being equivalent to Lu | Ll | Lt. Also add support for \p{L&} which is the PCRE spelling of \p{Lc}.

This is defined in UAX#44 as being equivalent to
`Lu | Ll | Lt`.
This is a PCRE spelling for a cased letter.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight requested review from Azoy and milseman May 3, 2022 12:51
@hamishknight hamishknight changed the title Add matching support for \p{Lc} Add matching support for \p{Lc} and \p{L&} May 3, 2022
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamishknight hamishknight merged commit ade8f01 into swiftlang:main May 3, 2022
@hamishknight hamishknight deleted the case-in-prop branch May 3, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants