Implement .as for Regex and Unify Match and AnyRegexOutput #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azoy
force-pushed
the
types-types-and-more-types
branch
from
592e377 to
7e1ab7d
Compare
|
@swift-ci please test |
milseman
reviewed
May 11, 2022
| @@ -17,17 +17,13 @@ extension Regex { | |||
| /// providing direct access to captures. | |||
| @dynamicMemberLookup | |||
| public struct Match { | |||
| let input: String | |||
| let anyRegexOutput: AnyRegexOutput | |||
|
|
|||
| /// The range of the overall match. | |||
| public let range: Range<String.Index> | |||
There was a problem hiding this comment.
The ARO inside of Match does not store it, but match.output where Output == ARO does store it.
There was a problem hiding this comment.
Wait, so sometimes ARO stores it and sometimes it doesn't? That seems like a footgun.
|
@swift-ci please test |
|
@milseman anything else for this? |
milseman
approved these changes
May 13, 2022
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.