De-deprecate MatchingOptions.matchLevel #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had marked this as deprecated in an ill-advised effort to encourage refactoring `_CharacterClassModel.MatchLevel` out of existence, but so far it's only had the effect of generating annoying build warnings.
|
@swift-ci Please test |
|
Why is refactoring it out of existence ill-advised? |
|
Sorry, the refactoring is probably a good idea eventually, along with a lot of other refactoring. The ill-advised part was thinking that the deprecation warning would increase the priority of that refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had marked this as deprecated in an ill-advised effort to encourage refactoring
_CharacterClassModel.MatchLevelout of existence, but so far it's only had the effect of generating annoying build warnings.Resolves #284.