Skip to content

Catch more unquantifiable elements #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2022

Conversation

natecook1000
Copy link
Member

This adds start/end anchors ^ and $, groups that form zero-width assertions, and option-changing groups.

This adds start/end anchors ^ and $, groups that form zero-width
assertions, and option-changing groups.
@natecook1000 natecook1000 requested a review from hamishknight May 9, 2022 23:10
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure whether or not we want to ban quantified change matching option groups, but otherwise this LGTM!

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit f779459 into swiftlang:main May 10, 2022
@natecook1000 natecook1000 deleted the addl_unquantifiables branch May 10, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants