Skip to content

Disable resilience on _RegexParser #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented May 11, 2022

_RegexParser does not need resilience as it's only ever going to be used by _StringProcessing and RegexBuilder.

@rxwei rxwei requested a review from milseman May 11, 2022 00:54
@rxwei
Copy link
Contributor Author

rxwei commented May 11, 2022

@swift-ci please test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxwei rxwei merged commit 87ea119 into swiftlang:main May 11, 2022
@rxwei rxwei deleted the regex-parser-not-resilient branch May 11, 2022 16:50
@milseman
Copy link
Member

Do we want to get this in for 5.7?

@rxwei
Copy link
Contributor Author

rxwei commented May 12, 2022

Yes. Haven’t got a chance yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants