[5.7-04182022] Introduce One
#407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One is a lightweight component that allows the use of the leading dot syntax to reference `RegexComponent` static members such as character classes as a non-first expression in a regex builder block.
---
Before:
```swift
Regex {
.digit // works today but brittle; inserting anything above this line will break this
OneOrMore(.whitespace)
.word // ❌ error: 'OneOrMore' has no member named 'word' (because this is parsed as a member reference on the preceeding expression)
}
```
After:
```swift
Regex {
One(.digit) // recommended even though `.digit` works today
OneOrMore(.whitespace)
One(.word)
} // ✅
```
In a follow-up patch, we will propose adding an additional protocol inheriting from `RegexComponent` that will ban the use of the leading dot syntax even on the first line of `Regex { ... }`, as this will enforce the recommended style (use of `One`), and prevent surprises when the user inserts a pattern above the leading dot line.
stephentyrone
approved these changes
May 12, 2022
natecook1000
added a commit
to natecook1000/swift-experimental-string-processing
that referenced
this pull request
May 18, 2022
Character class ranges don't work well with multi-scalar inputs, in either the range or the matched character. This change limits range endpoints to single-scalar characters and matches only characters that are themselves a single scalar. Fixes issue swiftlang#407, which now displays this behavior: ``` try /[1-2]/.wholeMatch(in: "1️⃣") // nil try /[12]/.wholeMatch(in: "1️⃣") // nil try /(?U)[\d]/.wholeMatch(in: "1️⃣") // nil ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #403
One is a lightweight component that allows the use of the leading dot syntax to reference
RegexComponentstatic members such as character classes as a non-first expression in a regex builder block.Before:
After:
In a follow-up patch, we will propose adding an additional protocol inheriting from
RegexComponentthat will ban the use of the leading dot syntax even on the first line ofRegex { ... }, as this will enforce the recommended style (use ofOne), and prevent surprises when the user inserts a pattern above the leading dot line.