Skip to content

Wrap character classes around One #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2022
Merged

Wrap character classes around One #410

merged 2 commits into from
May 13, 2022

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented May 12, 2022

This PR wraps character classes like .digit around One(.digit) in contexts where it will be treated as a member reference. I also made the change to force syntax like:

OneOrMore(.digit)

to avoid the inevitable:

OneOrMore {
  One(.digit)
}

(DSL printing needs a refactor)

@Azoy Azoy requested review from milseman and DaveEwing May 12, 2022 22:11
@Azoy
Copy link
Contributor Author

Azoy commented May 13, 2022

@swift-ci please test

@Azoy Azoy merged commit 489c63c into swiftlang:main May 13, 2022
@Azoy Azoy deleted the more-patternconverter-updates branch May 13, 2022 03:13
@hamishknight hamishknight mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveEwing DaveEwing DaveEwing approved these changes

@milseman milseman Awaiting requested review from milseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azoy @DaveEwing