Skip to content

Remove the last SPI use of _RegexParser symbols #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2022

Conversation

natecook1000
Copy link
Member

PatternConverter uses one last AST-based API defined in _StringProcessing, which is technically not allowed but not
problematic b/c PatternConverter also imports _RegexParser. However, this can have compile-time problems later on, so this changes the entry point for PatternConverter to just use an Any parameter that is checked at runtime to actually be AST.

PatternConverter uses one last AST-based API defined in
_StringProcessing, which is technically not allowed but not
problematic b/c PatternConverter also imports _RegexParser.
However, this can have compile-time problems later on, so
this changes the entry point for PatternConverter to just use
an Any parameter that is checked at runtime to actually be AST.
@natecook1000 natecook1000 requested a review from rxwei May 15, 2022 02:31
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit 4f8f67a into swiftlang:main May 15, 2022
@natecook1000 natecook1000 deleted the no_more_public_spi branch May 15, 2022 04:44
natecook1000 added a commit to natecook1000/swift-experimental-string-processing that referenced this pull request May 15, 2022
PatternConverter uses one last AST-based API defined in
_StringProcessing, which is technically not allowed but not
problematic b/c PatternConverter also imports _RegexParser.
However, this can have compile-time problems later on, so
this changes the entry point for PatternConverter to just use
an Any parameter that is checked at runtime to actually be AST.
natecook1000 added a commit that referenced this pull request May 16, 2022
PatternConverter uses one last AST-based API defined in
_StringProcessing, which is technically not allowed but not
problematic b/c PatternConverter also imports _RegexParser.
However, this can have compile-time problems later on, so
this changes the entry point for PatternConverter to just use
an Any parameter that is checked at runtime to actually be AST.
natecook1000 added a commit to natecook1000/swift-experimental-string-processing that referenced this pull request May 16, 2022
…tlang#417)

PatternConverter uses one last AST-based API defined in
_StringProcessing, which is technically not allowed but not
problematic b/c PatternConverter also imports _RegexParser.
However, this can have compile-time problems later on, so
this changes the entry point for PatternConverter to just use
an Any parameter that is checked at runtime to actually be AST.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants